add_heir_dialect_library build macro for bazel #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2kun
added
the
pull_ready
|
So I am patching this internally to fix the conflicts, and I will merge it, but I have a request to make for any followups to this: the generated target name and the file being read should always be provided as input to the macro. This will require more typing, but will be more readable, otherwise when looking at a target with a dependency like Filed #1242 to remind us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1045, similar to #1055 and see also #1235 where the verbose
gentbl_cc_libraryis error-prone.This PR demos the usability of such macro for LWE/Openfhe dialect. If such change is favored, further PR will update other BUILD file and the template generator.