Migrate TypeAsmInterface to OpAsmTypeInterface #1435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upstreaming of https://discourse.llvm.org/t/rfc-introduce-opasm-type-attr-interface-for-pretty-print-in-asmprinter/83792, we now have
OpAsmTypeInterface
andOpAsmAttrInterface
that is directly hooked into the MLIR AsmPrinter, so there is a series of updateTypeAsmInterface
toOpAsmTypeInterface getAsmName
method (this PR)OpAsmDialectInterface getAlias(Type)
toOpAsmTypeInterface getAlias
OpAsmDialectInterface getAlias(Attr)
toOpAsmAttrInterface getAlias
The good thing about using
OpAsmTypeInterface
is that we now do not need to hack intofunc::FuncOp OpAsmOpInterface
to make it also work for function argument; also all our op and op from MLIR (likeaffine.for
) would respect the TypeInterface instead of manually hook into their OpInterface.One behavior change is the grouping behavior of multi-result op. Previously it would be
%0:4
now it becomes four separate SSA.