Skip to content

Improve handling of undo/redo events in web demo (#1254) #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve handling of undo/redo events in web demo (#1254) #1255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fcffe7
Add synchronization to demo (#1254)
garyg1 Sep 4, 2025
70e567f
Update doc/js/demo.js
garyg1 Sep 4, 2025
db03341
Update doc/js/demo.js
garyg1 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 67 additions & 54 deletions doc/js/demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,70 +123,83 @@ function aux_demo(input_id, input_files, main_file, output_id, process_func) {

for (let textarea_id in editor_by_textarea_id) {
let editor = editor_by_textarea_id[textarea_id];
let startedJobId = 0;
let finishedJobId = 0;
editor.on('change', async function() {
// Clean out the existing textareas and tabs.
// There should be only one.
let tab_header = output.getElementsByClassName('tab-header')[0];
let last_selected;
while (tab_header.firstChild) {
let child = tab_header.firstChild;
if (child.className == 'selected') {
last_selected = child.innerHTML;
}
tab_header.removeChild(child);
// Yield until we finish duplicated change events (#1254)
startedJobId += 1;
const currJobId = startedJobId;
while (finishedJobId < currJobId - 1) {
await new Promise(resolve => setTimeout(resolve, 10));
}

let condemned_textareas = output.getElementsByTagName('TEXTAREA');
let last_scroll = 0;
while (condemned_textareas[0]) {
if (condemned_textareas[0].classList.contains('selected')) {
last_scroll = condemned_textareas[0].scrollTop;
try {
// Clean out the existing textareas and tabs.
// There should be only one.
let tab_header = output.getElementsByClassName('tab-header')[0];
let last_selected;
while (tab_header.firstChild) {
let child = tab_header.firstChild;
if (child.className == 'selected') {
last_selected = child.innerHTML;
}
tab_header.removeChild(child);
}
output.removeChild(condemned_textareas[0]);
}

let condemned_textareas = output.getElementsByTagName('TEXTAREA');
let last_scroll = 0;
while (condemned_textareas[0]) {
if (condemned_textareas[0].classList.contains('selected')) {
last_scroll = condemned_textareas[0].scrollTop;
}
output.removeChild(condemned_textareas[0]);
}

let input_files_content = {};
for (let id in input_files) {
let file = input_files[id];
let file_editor = editor_by_textarea_id[id];
input_files_content[file] = file_editor.getValue();
}
function add_textarea_and_tab(filename, selected, scroll, output_content, output_class) {
let output_textarea = document.createElement('TEXTAREA');
let id = 'output-' + counter++;
output_textarea.setAttribute('id', id);
output_textarea.value = output_content;
output.appendChild(output_textarea);

let selected_class = 'unselected';
if (filename == selected) {
selected_class = 'selected';
output_textarea.scrollTop = scroll;
}
output_textarea.className = selected_class + ' ' + output_class;
let max_height = 300;
for (let id in editor_by_textarea_id) {
let editor_div = editor_by_textarea_id[id].getWrapperElement();
max_height = Math.max(max_height, editor_div.offsetHeight);
let input_files_content = {};
for (let id in input_files) {
let file = input_files[id];
let file_editor = editor_by_textarea_id[id];
input_files_content[file] = file_editor.getValue();
}
resize_textarea_max(max_height, output_textarea);
function add_textarea_and_tab(filename, selected, scroll, output_content, output_class) {
let output_textarea = document.createElement('TEXTAREA');
let id = 'output-' + counter++;
output_textarea.setAttribute('id', id);
output_textarea.value = output_content;
output.appendChild(output_textarea);

let output_tab = document.createElement('DIV');
tab_header.appendChild(output_tab);
output_tab.className = selected_class;
output_tab.onclick = function() { tab_output_click(this, output_textarea.id); };
output_tab.innerHTML = filename;
}
try {
await process_func(
main_file, input_files_content, last_selected, last_scroll, add_textarea_and_tab);
} catch (e) {
if (typeof e === 'string') {
// Remove last \n
e = e.replace(/\n$/, '');
let selected_class = 'unselected';
if (filename == selected) {
selected_class = 'selected';
output_textarea.scrollTop = scroll;
}
output_textarea.className = selected_class + ' ' + output_class;
let max_height = 300;
for (let id in editor_by_textarea_id) {
let editor_div = editor_by_textarea_id[id].getWrapperElement();
max_height = Math.max(max_height, editor_div.offsetHeight);
}
resize_textarea_max(max_height, output_textarea);

let output_tab = document.createElement('DIV');
tab_header.appendChild(output_tab);
output_tab.className = selected_class;
output_tab.onclick = function() { tab_output_click(this, output_textarea.id); };
output_tab.innerHTML = filename;
}
try {
await process_func(
main_file, input_files_content, last_selected, last_scroll, add_textarea_and_tab);
} catch (e) {
if (typeof e === 'string') {
// Remove last \n
e = e.replace(/\n$/, '');
}
add_textarea_and_tab(last_selected, last_selected, last_scroll, e, 'code-error');
}
add_textarea_and_tab(last_selected, last_selected, last_scroll, e, 'code-error');
} finally {
finishedJobId = Math.max(finishedJobId, currJobId);
}
});
}
Expand Down