better lone parenthesis handling (#250)

google · Apr 9, 2020 · d65a386 · d65a386
1 parent 8a8f26b
commit d65a386
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/lib/Symbols.js b/lib/Symbols.js
@@ -39,6 +39,10 @@ Symbols.getLastSymbolTerm = function(node, symbolName) {
       }
     }
   }
+  else if (Node.Type.isParenthesis(node)) {
+    return Symbols.getLastSymbolTerm(node.content, symbolName);
+  }
+
   return null;
 };
 

diff --git a/lib/solveEquation/EquationOperations.js b/lib/solveEquation/EquationOperations.js
@@ -128,10 +128,16 @@ EquationOperations.removeSymbolFromRightSide = function(equation, symbolName) {
 // or dividing all other symbols and constants from both sides appropriately
 // TODO: support inverting functions e.g. sqrt, ^, log etc.
 EquationOperations.isolateSymbolOnLeftSide = function(equation, symbolName) {
-  const leftNode = equation.leftNode;
-  let nonSymbolTerm = Symbols.getLastNonSymbolTerm(leftNode, symbolName);
+  let leftNode = equation.leftNode;
+
+  if (Node.Type.isParenthesis(leftNode)) {
+    // if entire left node is a parenthesis, we can ignore the parenthesis
+    leftNode = leftNode.content;
+  }
 
+  let nonSymbolTerm = Symbols.getLastNonSymbolTerm(leftNode, symbolName);
   let inverseOp, inverseTerm, changeType;
+
   if (!nonSymbolTerm) {
     return EquationStatus.noChange(equation);
   }

diff --git a/test/solveEquation/solveEquation.test.js b/test/solveEquation/solveEquation.test.js
@@ -95,6 +95,8 @@ describe('solveEquation for =', function () {
     ['2/(1 + 1 + 4x) = 1/3', 'x = 1'],
     ['(3 + x) / (x^2 + 3) = 1', 'x = [0, 1]'],
     ['6/x + 8/(2x) = 10', 'x = 1'],
+    ['(x+1)=4', 'x = 3'],
+    ['((x)/(4))=4', 'x = 16']
     // TODO: fix these cases, fail because lack of factoring support, for complex #s,
     // for taking the sqrt of both sides, etc
     // ['(x + y) (y + 2) = 0', 'y = -y'],
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,6 +39,10 @@ Symbols.getLastSymbolTerm = function(node, symbolName) { @@
           }
         }
       }
+      else if (Node.Type.isParenthesis(node)) {
+        return Symbols.getLastSymbolTerm(node.content, symbolName);
+      }
       return null;
     };
@@ Expand Down @@