fixed string quotes type

google · Jan 3, 2023 · 9bddc70 · 9bddc70
1 parent 5961b65
commit 9bddc70
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/packages/model-viewer/src/features/ar.ts b/packages/model-viewer/src/features/ar.ts
@@ -434,27 +434,29 @@ configuration or device capabilities');
 
       const usdzOptions = {
         ar: {
-          anchoring: { type: "plane" },
+          anchoring: { type: 'plane' },
           planeAnchoring: {
-            alignment: this.arPlacement === "wall" ? "vertical" : "horizontal",
+            alignment: this.arPlacement === 'wall' ? 'vertical' : 'horizontal',
           },
         },
       };
 
-      if (usdzOptions.ar.planeAnchoring.alignment === "vertical") {
+      // necessary because quicklook internally rotates model when placing vertical. 
+      // See https://github.com/google/model-viewer/issues/3989
+      if (usdzOptions.ar.planeAnchoring.alignment === 'vertical') {
         model.rotateX((-90 * Math.PI) / 180);
         model.updateMatrixWorld();
       }
 
       const exporter = new USDZExporter() as any;
       const arraybuffer = await exporter.parse(model, usdzOptions);
       const blob = new Blob([arraybuffer], {
-        type: "model/vnd.usdz+zip",
+        type: 'model/vnd.usdz+zip',
       });
 
       const url = URL.createObjectURL(blob);
 
-      if (usdzOptions.ar.planeAnchoring.alignment === "vertical") {
+      if (usdzOptions.ar.planeAnchoring.alignment === 'vertical') {
         model.rotateX((90 * Math.PI) / 180);
         model.updateMatrixWorld();
       }