Propagate batch_padding_policy through BatchOptions in JSV #2346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_803096545
branch
5 times, most recently
from
45d2093 to
e3dcdf2
Compare
- Propagate batch_padding_policy from BatchOptions -> BatchRunnerOpOptions -> QueueOptions. - Temporarily convert batch_padding_policy to string for propagation. Add TODOs to use BatchPaddingPolicy enum when BATCH_DOWN and MINIMIZE_TPU_COST_PER_REQUEST are supported. PiperOrigin-RevId: 803096545
copybara-service
bot
force-pushed
the
test_803096545
branch
from
e3dcdf2 to
2b2a0b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate batch_padding_policy through BatchOptions in JSV