Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lit, TypeScript, and eslint #382

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Update Lit, TypeScript, and eslint #382

merged 3 commits into from
Nov 22, 2023

Conversation

justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Oct 15, 2023

This is the start of a few tasks to update the dependencies, starting with the runtime dependencies (and eslint because it need to updated with TypeScript). This is separate from a PR to update MWC because the MWC update is going to be a bit more invasive.

@justinfagnani justinfagnani changed the title Update Lit and TYpeScript Update Lit, TypeScript, and eslint Oct 15, 2023
Copy link
Collaborator

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Brilliant!

@AndrewJakubowicz
Copy link
Collaborator

AndrewJakubowicz commented Nov 22, 2023

I tested this manually.
npm run serve: configurator works great!
npm run test: passes.

I'll see if I can re-kick the test GitHub action that failed, and then I'll merge. Actions were too stale to manually re-run. Instead I created an empty commit.

@AndrewJakubowicz
Copy link
Collaborator

I re-ran test (it's unfortunately flakey). It did pass on the third try.

@AndrewJakubowicz AndrewJakubowicz merged commit 830af05 into main Nov 22, 2023
8 of 9 checks passed
@AndrewJakubowicz AndrewJakubowicz deleted the update-deps branch November 22, 2023 22:17
@AndrewJakubowicz AndrewJakubowicz mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants