Update runtime and test dependencies #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
approved these changes
Aug 16, 2024
|
I can't see from the logs what's causing Firefox to fail on CI, and tests pass locally for me. I'm going to try to update the testing deps and see if that helps. |
|
@aomarks looks like tests pass with going all-in on Playwright! Do you want a separate PR for updating the test deps, or is this one ok? |
aomarks
approved these changes
Aug 19, 2024
One seems good |
justinfagnani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of Fuse.js and tslib play better with modules since they define exports for JS and types.