Skip to content

Fix failing test #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix failing test #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a52a34c
Fix testPromiseWhenNilBridgesToThenChain to assert nil instead of NSNull
bc-lee Apr 20, 2025
81e52ea
Update .gitignore to exclude SwiftPM configuration files
bc-lee Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
Packages/
.build/
*.resolved
.swiftpm/configuration/registries.json
.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

# Bazel

Expand Down
6 changes: 3 additions & 3 deletions Tests/PromisesTests/Promise+ThenTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,20 +59,20 @@ class PromiseThenTests: XCTestCase {
XCTAssertNil(postFinalPromise.error)
}

func testPromiseWhenNilBridgesToNSNullInThenChain() {
func testPromiseWhenNilBridgesToNilInThenChain() {
// Act.
let promise = Promise<Any?> { fulfill, _ in
fulfill(nil)
}.catch { _ in
XCTFail()
}.then { value in
XCTAssert(value is NSNull)
XCTAssertNil(value)
}

// Assert.
XCTAssert(waitForPromises(timeout: 10))
XCTAssertTrue(promise.isFulfilled)
XCTAssert(promise.value is NSNull)
XCTAssertNil(promise.value)
XCTAssertNil(promise.error)
}

Expand Down