Make _abstract a real module-like object #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/692727204
branch
4 times, most recently
from
68befc3 to
5d74859
Compare
Drop the string-based functions `_isinstance` and `_make`, instead use the real objects directly. Very similarly to the prior situation, the actual `abstract` module will be lazily loaded only after the first access of such an attribute. PiperOrigin-RevId: 694271269
copybara-service
bot
force-pushed
the
cl/692727204
branch
from
5d74859 to
2510d70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make _abstract a real module-like object
Drop the string-based functions
_isinstanceand_make, instead use the real objects directly.Very similarly to the prior situation, the actual
abstractmodule will be lazily loaded only after the first access of such an attribute.