Eliminate magic constants usage #508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ukane-philemon
suggested changes
Apr 29, 2024
| * User response token parameter name | ||
| * @const string | ||
| */ | ||
| const USER_TOKEN_PARAMETER = 'g-recaptcha-response'; |
There was a problem hiding this comment.
Consider renaming to USER_RESPONSE_TOKEN_PARAMETER or USER_RESPONSE_PARAMETER.
USER_TOKEN_PARAMETER does not ring a bell at first sight and the comment suggests better.
Contributor
There was a problem hiding this comment.
\ReCaptcha\ReCaptcha::RESPONSE_KEY would work for me here as it's then closer to the underlying string too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it would be better to use a predefined class constant instead of a magic constant in client code.