Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax: parameterize API over FileOptions, avoid globals #477

Merged
merged 1 commit into from
Aug 14, 2023
Merged

syntax: parameterize API over FileOptions, avoid globals #477

merged 1 commit into from
Aug 14, 2023

Commits on Aug 7, 2023

  1. syntax: parameterize API over FileOptions, avoid globals 

    This change eliminates the need for client applications
to set global variables to control dialect options,
as globals are error-prone and concurrency hostile.

All relevant API functions Foo now have a variant FooOptions
that takes an explicit FileOptions; the original function
accesses the legacy options by reading the global variables.

Fixes #435
    @adonovan
    adonovan committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    f669cc5 View commit details
    Browse the repository at this point in the history