-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete outdated k8s configuration and documentation #1356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to keep the scripts in the tools directory as they may still be useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a small nit around having a direct link instead to the OSDFIR Infra repo. You can also remove the k8s/tools/helper.sh
file as has been moved over to the OSDFIR Infra repo
The ones Ramses is deleting wouldn't work anymore given also remove the associated k8s files but we do have a gke init script ported into the OSDFIR infra here: https://github.com/google/osdfir-infrastructure/blob/main/tools/init-gke.sh Maybe we want to look back on some of the monitoring work we've done in case we can reuse some of our logic (pending what solution we end up with) but we can always refer back to this PR or older branch to see what was changed. |
Co-authored-by: Wajih Yassine <54372074+wajihyassine@users.noreply.github.com>
@wajihyassine proposed change commited and comment resolved PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
Delete k8s configuration and documentation as this has been replaced with the OSDFIR infrastructure repository. https://github.com/google/osdfir-infrastructure
Checklist