-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update turbinia-api-client and turbinia-client #1357
Conversation
Locking fastapi to <= 0.98.0 until openapi-generator supports OpenAPI 3.1.0 specs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The API library handles reading the file data and setting the content type.
New changes, LGTM too |
* Update turbinia-api-client and turbinia-client Locking fastapi to <= 0.98.0 until openapi-generator supports OpenAPI 3.1.0 specs * Update turbinia-api-lib * Update * Updates to requirements * Updates to upload_evidence parameters The API library handles reading the file data and setting the content type.
@jleaniz if you want openapi v3.1.0 support, have you considered using openapi-json-schema-generator?
|
@spacether thanks for pointing that out. I wasn't aware of openapi-json-schema-generator, I'll check it out. Is the python generator from |
|
Description of the change
This PR updates
turbinia-api-lib
andturbinia-client
The Python API library was generated using
openapi-generator
(latest release v7.0.1). The requirements in this version align with fastapi < 0.99.0 because newer versions produce OpenAPI 3.1 specs which the generator does not yet fully support. For this reason, I am locking fastapi to <0.99.0 temporarily to be consistent with the requirements inturbinia-api-lib
forpydantic
andurllib3
Once support for OpenAPI 3.1 is fully implemented in the
openapi-generator
, we can loosen the FastAPI version.Additionally, we should not be using urrlib3[secure] extra because it'll be deprecated (see urllib3/urllib3#2680) -- so i adjusted the requirement.
Applicable issues
Additional information
raw_data
attribute. Theread_chunks
method is no longer available to the client.upload_evidence
method. The API library now handles file reading for the client, so we just pass a list of file paths instead.Checklist