Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unique tasks and sort/filtering in report output #1395

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Fix unique tasks and sort/filtering in report output #1395

merged 3 commits into from
Nov 16, 2023

Conversation

aarontp
Copy link
Member

@aarontp aarontp commented Nov 15, 2023 •
edited
Loading

Description of the change

  • Fixes unique task summary counts so we can remove duplicate task outputs in the report to make it more succinct.
  • Also sort request summary tasks output by last update time.
  • Also set default priority filter for task status requests so all details are shown.

Applicable issues

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@aarontp aarontp changed the title Fix unique task counts/summaries in request report Fix unique tasks and sort/filtering in report output Nov 15, 2023
@aarontp aarontp requested a review from jleaniz November 16, 2023 20:20
jleaniz
jleaniz approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleaniz jleaniz merged commit 405b657 into google:master Nov 16, 2023
5 checks passed
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Feb 28, 2024
@aarontp @jleaniz
Fix unique tasks and sort/filtering in report output (google#1395)
2b5d9e4 
* Move unique task check

* Add sorting to request summary

* Add default priority filter for task
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Mar 18, 2024
@aarontp @jleaniz
Fix unique tasks and sort/filtering in report output (google#1395)
63fa70c 
* Move unique task check

* Add sorting to request summary

* Add default priority filter for task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleaniz jleaniz jleaniz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarontp @jleaniz