Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage to test run script. #1406

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Add test coverage to test run script. #1406

merged 5 commits into from
Dec 15, 2023

Conversation

hacktobeer
Copy link
Collaborator

Description of the change

Add test coverage to test run script (run_tests.py)

Applicable issues

Checklist

  • All tests were successful.

@hacktobeer
Copy link
Collaborator Author

hacktobeer commented Dec 11, 2023 •
edited
Loading

@jleaniz There seems to be a dependency issue with the unit test image build? Any ideas?
https://github.com/google/turbinia/actions/runs/7167242287/job/19512947605?pr=1406#step:4:2929

^ fixed below (@hacktobeer)

@hacktobeer hacktobeer requested a review from jleaniz December 11, 2023 12:24
@hacktobeer
Copy link
Collaborator Author

I think I fixed it:

  • updated libbde-python (which pulled in a couple of other updated packages)
  • locked poetry lock file
  • updated yara test as new rules generate 4 detections instead of 3

@jleaniz PTAL if I did the poetry stuff right....

@hacktobeer
Copy link
Collaborator Author

Test coverage output - https://github.com/google/turbinia/actions/runs/7183560134/job/19562612102?pr=1406#step:7:2011

@hacktobeer hacktobeer requested a review from aarontp December 13, 2023 08:15
@wajihyassine wajihyassine mentioned this pull request Dec 14, 2023
Merged
1 task
@wajihyassine wajihyassine self-requested a review December 14, 2023 19:41
wajihyassine
wajihyassine approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for fixing the broken tests the poetry updates look right to me

@wajihyassine
Copy link
Member

I also chatted with @aarontp and said it was fine to merge to fix the tests since @jleaniz will be out for some time

@wajihyassine wajihyassine merged commit bfc586e into google:master Dec 15, 2023
5 checks passed
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Feb 28, 2024
@hacktobeer @jleaniz
Add test coverage to test run script. (google#1406)
fbb71ea 
* add coverage to run_tests

* add coverage to test run script

* updated libbde-python

* update yara test message (rules updated)
jleaniz pushed a commit to jleaniz/turbinia that referenced this pull request Mar 18, 2024
@hacktobeer @jleaniz
Add test coverage to test run script. (google#1406)
8fefa7b 
* add coverage to run_tests

* add coverage to test run script

* updated libbde-python

* update yara test message (rules updated)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wajihyassine wajihyassine wajihyassine approved these changes

@jleaniz jleaniz Awaiting requested review from jleaniz

@aarontp aarontp Awaiting requested review from aarontp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test coverage no longer showing by default
2 participants
@hacktobeer @wajihyassine