Add unit tests for notify.py #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, always glad to see more tests :). Is this ready for review? |
I forgot about this PR, yes, let's review. I'll assign. |
aarontp
approved these changes
Jan 11, 2024
| # Test that email is not sent when EMAIL_PASSWORD is not defined | ||
| mock_smtp.reset_mock() | ||
| self.config.EMAIL_PASSWORD = '' | ||
| with self.assertLogs('turbinia', level='INFO') as turbinia_info_log: |
There was a problem hiding this comment.
woah, cool, I didn't know assertLogs was a thing, nice.
| pass | ||
| self.assertEqual( | ||
| turbinia_error_log.output[1], | ||
| 'ERROR:turbinia:Email failed to send, SMTP has raised an error, ' |
There was a problem hiding this comment.
Normally I might say this is a little brittle since it will fail if the logging message or formatting changes, but this notify module hasn't changed in quite a while so I think it's probably just fine to leave it for now, and if things change we can update as needed (e.g. have a different check, or maybe just check a substring).
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Feb 28, 2024
* Write missing notify.py test. 100% coverage reported. * yapf
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Mar 18, 2024
* Write missing notify.py test. 100% coverage reported. * yapf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds unit tests for notify.py as it lacks any unit tests.
Applicable issues
None
Checklist