Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed EWF support #1438

Closed
wants to merge 4 commits into from
Closed

Fixed EWF support #1438

wants to merge 4 commits into from

Conversation

Slaynot
Copy link
Contributor

@Slaynot Slaynot commented Feb 18, 2024

Description of the change

Applicable issues

Additional information

The bug was introduced in the worker Dockerfile in 3450b2d.

Checklist

  • [ x] All tests were successful.
  • [ x] Unit tests added.

Copy link

google-cla bot commented Feb 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jleaniz
Copy link
Collaborator

jleaniz commented Feb 19, 2024

Hi @Slaynot - thanks for the contribution. Could you please sign the CLA for us to be able to merge these changes?

@Slaynot
Copy link
Contributor Author

Slaynot commented Feb 19, 2024

I did, the check seems to not work as the email associated with the commits is not the same as the one used to sign the CLA. Not too sure what I can do about that.

@jleaniz
Copy link
Collaborator

jleaniz commented Feb 19, 2024

@aarontp do you know how to fix the CLA issue without having to reopen the PR?

@aarontp
Copy link
Member

aarontp commented Feb 21, 2024

I'm not sure if we can retrigger this with another email address, but I'll look into that.

@jleaniz
Copy link
Collaborator

jleaniz commented Feb 21, 2024

@Slaynot if you want to expedite this being merged, it's probably best to reopen the PR and make sure all commits use the same user/email you signed the CLA with.

Slaynot and others added 4 commits February 21, 2024 18:26
* Update turbiniacli.py

* Update auth_helper.py

* Update configuration.py

* Update turbiniacli.py

* Update configuration.py

go back to access_token to not break OpenAPI configs automation

* Update turbiniacli.py
@Slaynot Slaynot closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants