Conversation
jleaniz
force-pushed
the
task-status-v2
branch
from
1ba4b6a to
13e334d
Compare
aarontp
left a comment
aarontp
left a comment
There was a problem hiding this comment.
LGTM, thanks. I think adding the dedicated task state attribute makes a lot of sense and cleans it up.
One general note just for the record (not sure where else to record, this, maybe we want to put something in the PR description): Because we're updating the task object attributes after the task is scheduled I don't think we won't be able to update the full task data from the worker without clobbering some data there. This is fine because we're not doing this right now, but in the future we'll want to update at least the task status so we should keep that in mind then.
| """ | ||
| raise NotImplementedError | ||
|
|
||
| def update_task_status(self, task, status=None): |
There was a problem hiding this comment.
I think we will want to update the task status from the task in order to get mid-run updates, but we can always add this or similar back in when we actually utilize that.
2 participants
Description of the change
Refactor task status tracking in task_manager to utilize Celery state to determine actual task status.
Applicable issues
Additional information
Checklist