[codegen] reject zero-bit literals, they are invalid in verilog#4050
Draft
cdleary wants to merge 3 commits intogoogle:mainfrom
Draft
[codegen] reject zero-bit literals, they are invalid in verilog#4050cdleary wants to merge 3 commits intogoogle:mainfrom
cdleary wants to merge 3 commits intogoogle:mainfrom
Conversation
425bd80 to
f9d0856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0'h0Literal(...)API and aLiteralOrDie(...)convenience wrapper, then propagate status through the relevant codegen and C API pathsJust a context note, this is observable if you fiddle with the passes via the new pass flag facilities, you just get errors in downstream tools like yosys since SV doesn't support this construct, erroring up front in the XLS tooling that we can't codegen verilog directly from the IR is more sound.