Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the calculation/correlation framework. #9

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Refactored the calculation/correlation framework. #9

merged 1 commit into from
Apr 20, 2024

Conversation

zond
Copy link
Collaborator

@zond zond commented Apr 19, 2024

  • Removed the optimization completely, it didn't work great and it
    should be simple to recreated when needed.
  • Replaced the dataset JSON data store with a Badger database.
  • Replaced the "load from remote datasets on demand but store it locally
    when preferred" with a "always download locally for processing"
    approach.
  • Made local datasets always use compressed formats - either the same
    bytestream as remote, or (if WAV) FLAC.

@zond zond marked this pull request as draft April 19, 2024 08:45
@zond zond force-pushed the scores branch 6 times, most recently from 7f45073 to d201b5c Compare April 20, 2024 12:59
@zond zond changed the title Replaced the dataset abstraction Refactored the calculation/correlation framework. Apr 20, 2024
@zond zond marked this pull request as ready for review April 20, 2024 13:00
- Removed the optimization completely, it didn't work great and it
  should be simple to recreated when needed.
- Replaced the dataset JSON data store with a Badger database.
- Replaced the "load from remote datasets on demand but store it locally
  when preferred" with a "always download locally for processing"
  approach.
- Made local datasets always use compressed formats - either the same
  bytestream as remote, or (if WAV) FLAC.
@zond zond enabled auto-merge (rebase) April 20, 2024 13:05
@zond zond merged commit d43895c into main Apr 20, 2024
2 checks passed
@zond zond deleted the scores branch April 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant