-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
special casing norm=2 for speedup #96
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zond
requested changes
Jun 13, 2024
Before: |Score type |MSE |Min score |Max score |Mean score | |-----------|------------------|------------------|------------------|------------------| |Zimtohrli |0.101641872045228 |0.563959418943879 |0.762245848804069 |0.686398636984063 | |ViSQOL |0.115330916105424 |0.520833375452983 |0.801480831107469 |0.675101633981268 | |2f |0.129541391104905 |0.484687555319526 |0.797475783883375 |0.661870345773127 | |PESQ |0.147425552045669 |0.342342966279351 |0.841271127756762 |0.647128996775172 | |CDPAM |0.153471222942756 |0.441558428344727 |0.728779141125759 |0.620699318941738 | |PARLAQ |0.185057687192323 |0.445261140223642 |0.784370761057963 |0.587162756572532 | |AQUA |0.223207996944378 |0.331645933512413 |0.739286336419790 |0.547804951221731 | |PEAQB |0.225217321572038 |0.278744167467764 |0.851011116004117 |0.553935720513487 | |DPAM |0.315810440183130 |0.186717781679534 |0.690564701717118 |0.460415212267967 | |WARP-Q |0.339686211572685 |0.067600137543649 |0.777119464646524 |0.475793617709890 | |GVPMOS |0.412937133868407 |0.006851162794410 |0.783946603687895 |0.412912222208318 | real 44m52.908s # not indicative as the terminal was blocked by another window and consequently blocking the computation on my desktop user 748m34.686s sys 219m0.831s After: |Score type |MSE |Min score |Max score |Mean score | |-----------|------------------|------------------|------------------|------------------| |Zimtohrli |0.101642192840456 |0.563959418943879 |0.762245848804069 |0.686398039616168 | |ViSQOL |0.115330916105424 |0.520833375452983 |0.801480831107469 |0.675101633981268 | |2f |0.129541391104905 |0.484687555319526 |0.797475783883375 |0.661870345773127 | |PESQ |0.147425552045669 |0.342342966279351 |0.841271127756762 |0.647128996775172 | |CDPAM |0.153471222942756 |0.441558428344727 |0.728779141125759 |0.620699318941738 | |PARLAQ |0.185057687192323 |0.445261140223642 |0.784370761057963 |0.587162756572532 | |AQUA |0.223207996944378 |0.331645933512413 |0.739286336419790 |0.547804951221731 | |PEAQB |0.225217321572038 |0.278744167467764 |0.851011116004117 |0.553935720513487 | |DPAM |0.315810440183130 |0.186717781679534 |0.690564701717118 |0.460415212267967 | |WARP-Q |0.339686211572685 |0.067600137543649 |0.777119464646524 |0.475793617709890 | |GVPMOS |0.412937133868407 |0.006851162794410 |0.783946603687895 |0.412912222208318 | real 13m52.362s user 625m20.070s sys 279m59.803s 17 % reduction in user time some more speedup on the gammatone filter side
Before:
After:
|
The benchmark was buggy. I'm submitting #99 instead of this one, since it goes even further in removing unnecessary garbage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
real 44m52.908s # not indicative as computation was blocked (progress bar filling the buffer?) for ~30 min
user 748m34.686s
sys 219m0.831s
After:
real 13m52.362s
user 625m20.070s
sys 279m59.803s
17 % reduction in user time
some more speedup on the gammatone filter side