refactor(cli): improve error handling for local script reading#1415
Open
mostuselessboy wants to merge 1 commit intogoogle:mainfrom
Open
refactor(cli): improve error handling for local script reading#1415mostuselessboy wants to merge 1 commit intogoogle:mainfrom
mostuselessboy wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
761b42d to
3ac91da
Compare
3ac91da to
9d4b5b9
Compare
antongolub
requested changes
Feb 23, 2026
| tempPath = getFilepath($.cwd, name, ext) | ||
| } else { | ||
| script = await fs.readFile(firstArg, 'utf8') | ||
| try { |
Collaborator
There was a problem hiding this comment.
- Pull this into a separate function
readScriptFromFile - rm
console.error. The exception will be caught and logged via main try-catch. - Rollback
scripts/*.mjsedits. Keep the PR purpose focus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggests an improvement
This PR standardizes error handling while reading a local scripts, bringing all of it in line with the recent improvements made to remote script fetching made in this commit (#1408).
Usage demo
npm run buildbefore committing and verified the bundle updates correctly.run test(node --test test/cli.test.js) and confirmed the new assertions pass.