Closed
Conversation
- Created a new test directory `examples/shopping_ads/tests/`. - Added initial placeholder test files for each example script in `examples/shopping_ads/`. - Updated `noxfile.py` to ensure tests in the new directory are discovered by changing the start directory for `unittest discover` from `tests` to `.` (project root). All shopping_ads examples were already using Google Ads API v19, so no changes were needed for that.
BenRKarl
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
BenRKarl
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
|
Closing this because we're going to approach example tests in a different way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/shopping_ads/tests/.examples/shopping_ads/.noxfile.pyto ensure tests in the new directory are discovered by changing the start directory forunittest discoverfromteststo.(project root).All shopping_ads examples were already using Google Ads API v19, so no changes were needed for that.