fix: allow trace id to switch within the same connection #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
GaoleMeng
force-pushed
the
feature_branch
branch
2 times, most recently
from
d0eeecf to
305a57b
Compare
There was a problem hiding this comment.
Although this is OK for now, eventually we will also want to update the traceId on the telemetryMetrics when we have a table switch. Since currently we only use traceId for Dataflow in the telemetryMetrics, and Dataflow does not attempt to change the traceId across streams, we don't need this now.
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
Outdated
Show resolved
Hide resolved
...bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/ConnectionWorkerTest.java
Outdated
Show resolved
Hide resolved
GaoleMeng
force-pushed
the
feature_branch
branch
from
305a57b to
b018c3e
Compare
GaoleMeng
force-pushed
the
feature_branch
branch
from
b018c3e to
7c02950
Compare
agrawal-siddharth
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow the trace id to be changeable within the same connection. So that the same connection pool could be used for multiple different trace id from different stream writer. We will pass a new trace id to server side once we detect a table switch
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.