Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add and update type hints #101

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore: add and update type hints #101

wants to merge 7 commits into from

Conversation

jackwotherspoon
Copy link
Contributor

This PR does two things:

  1. Adds missing return type hints to unblock ci: update mypy type check #78
  2. Updates type hints to use standard collections (list, tuple, dict).
    We can do this now that Python 3.8 was removed

As of Python 3.9 and PEP 585 standard collections can be subscripted in favor
of their typing counterparts which are now deprecated.

@jackwotherspoon jackwotherspoon self-assigned this Oct 16, 2024
@jackwotherspoon jackwotherspoon requested review from a team as code owners October 16, 2024 23:59
@product-auto-label product-auto-label bot added the api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant