-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CloudSQLMySQLEngine class #7
Conversation
self._region = region | ||
self._instance = instance | ||
self._database = database | ||
self.engine = self._create_connector_engine() if engine is None else engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we have some validation check on input argument? For example, if engine is given, we shouldn't take other arguments like project ID and region etc.
We don't have to do it in one CL, but having a TODO comment would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed engine
from __init__
entirely as I have removed from_engine
and from_connection_string
which were the methods passing in the engine
@totoleon ready for another pass |
Merging to unblock any future dev, can make any future comments/suggestions in follow-up PR |
Adding
CloudSQLMySQLEngine
that will be leveraged by the vector store, docloader and memory APIs.Add integration tests(being done in follow-up PR)Manually tested the following currently: