Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MySQLLoader): support load document by query #8

Merged
merged 8 commits into from
Jan 25, 2024
Merged

feat(MySQLLoader): support load document by query #8

merged 8 commits into from
Jan 25, 2024

Conversation

loeng2023
Copy link
Contributor

@loeng2023 loeng2023 commented Jan 25, 2024 •
edited by jackwotherspoon
Loading

  • Add MySQLDBLoader to support load doc by query.
  • Add integration test test_load_from_query
  • Configure integration.cloudbuild.yaml to run integration test
  • Minor change to MySQLEngine to make it works with Cloud Build credential.

@loeng2023 loeng2023 requested a review from a team as a code owner January 25, 2024 19:49
@jackwotherspoon jackwotherspoon removed the request for review from a team January 25, 2024 21:04
jackwotherspoon
jackwotherspoon requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a first pass, awesome stuff!

src/langchain_google_cloud_sql_mysql/doc_loader.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/doc_loader.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/doc_loader.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/doc_loader.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/doc_loader.py Outdated Show resolved Hide resolved
tests/integration_tests/test_doc_loader.py Outdated Show resolved Hide resolved
tests/integration_tests/test_doc_loader.py Outdated Show resolved Hide resolved
@jackwotherspoon jackwotherspoon changed the title feat: suppport load document by query feat: support load document by query Jan 25, 2024
jackwotherspoon
jackwotherspoon approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loeng2023 loeng2023 merged commit eb2cba1 into staging Jan 25, 2024
7 checks passed
@jackwotherspoon jackwotherspoon changed the title feat: support load document by query feat(MySQLLoader): support load document by query Jan 25, 2024
@loeng2023 loeng2023 deleted the doc-loader branch January 25, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

@totoleon totoleon Awaiting requested review from totoleon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loeng2023 @jackwotherspoon