Skip to content

Conversation

@julieqiu
Copy link
Member

@julieqiu julieqiu commented Jan 22, 2026

librarian now supports a -v flag. When -v is set, the command is printed to stdout.

Fixes #3547

@julieqiu julieqiu requested a review from a team as a code owner January 22, 2026 00:29
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @julieqiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the librarian command-line tool by adding a verbose logging option. Users can now enable a -v flag to see the underlying commands being executed by librarian printed to standard error, which can be particularly useful for debugging and understanding the tool's operations.

Highlights

  • Verbose Logging Flag: Introduced a global Verbose flag in the internal/command package to control verbose logging for executed commands.
  • Command Execution Visibility: Implemented conditional printing of executed commands to stderr within the RunWithEnv function when the Verbose flag is enabled, providing insight into the underlying operations.
  • CLI Integration: Added a new -v or --verbose command-line flag to the librarian application, allowing users to easily enable verbose output directly from the CLI.
  • Comprehensive Testing: Included comprehensive unit tests for the new verbose functionality, covering both the command execution logic and the CLI flag integration to ensure correctness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@julieqiu julieqiu requested a review from zhumin8 January 22, 2026 00:30
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a -v flag for verbose logging, which prints the executed command to stderr. The implementation is clean and includes comprehensive tests for both the new functionality and the flag parsing. My review focuses on improving code clarity and adhering to the repository's Go style guide. I've suggested adding doc comments to exported test functions, using cmp.Diff for test assertions as prescribed, and simplifying a test helper function. I also added a note reinforcing the existing TODO to refactor the global configuration variable, which is a good practice for maintainability.

@julieqiu julieqiu force-pushed the verbose branch 2 times, most recently from ac0675f to 2998ad7 Compare January 22, 2026 00:42
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.47%. Comparing base (3dbe74f) to head (6559f46).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3688      +/-   ##
==========================================
+ Coverage   82.43%   82.47%   +0.03%     
==========================================
  Files         138      138              
  Lines       12657    12660       +3     
==========================================
+ Hits        10434    10441       +7     
+ Misses       1733     1730       -3     
+ Partials      490      489       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

librarian now supports a -v flag. When -v is set,
`running: <command>` is printed to stderr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

librarian: add -v flag for verbose output

1 participant