-
Notifications
You must be signed in to change notification settings - Fork 37
feat(internal/command): add -v flag #3688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @julieqiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a -v flag for verbose logging, which prints the executed command to stderr. The implementation is clean and includes comprehensive tests for both the new functionality and the flag parsing. My review focuses on improving code clarity and adhering to the repository's Go style guide. I've suggested adding doc comments to exported test functions, using cmp.Diff for test assertions as prescribed, and simplifying a test helper function. I also added a note reinforcing the existing TODO to refactor the global configuration variable, which is a good practice for maintainability.
ac0675f to
2998ad7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3688 +/- ##
==========================================
+ Coverage 82.43% 82.47% +0.03%
==========================================
Files 138 138
Lines 12657 12660 +3
==========================================
+ Hits 10434 10441 +7
+ Misses 1733 1730 -3
+ Partials 490 489 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
librarian now supports a -v flag. When -v is set, `running: <command>` is printed to stderr.
librarian now supports a -v flag. When -v is set, the command is printed to stdout.
Fixes #3547