deps: remove scikit-learn as a required dependency #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Genesis929
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Genesis929
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
GarrettWu
approved these changes
Jan 17, 2025
tswast
reviewed
Jan 21, 2025
Comment on lines
+181
to
+197
| if len(x_pandas) < 2: | ||
| raise ValueError( | ||
| f"At least 2 points are needed to compute area under curve, but x.shape = {len(x_pandas)}" | ||
| ) | ||
|
|
||
| if x_pandas.is_monotonic_decreasing: | ||
| d = -1 | ||
| elif x_pandas.is_monotonic_increasing: | ||
| d = 1 | ||
| else: | ||
| raise ValueError(f"x is neither increasing nor decreasing : {x_pandas}.") | ||
|
|
||
| if hasattr(np, "trapezoid"): | ||
| # new in numpy 2.0 | ||
| return d * np.trapezoid(y_pandas, x_pandas) | ||
| # np.trapz has been deprecated in 2.0 | ||
| return d * np.trapz(y_pandas, x_pandas) # type: ignore |
There was a problem hiding this comment.
If this code is copied from sklearn, we should put it in the third_party/bigframes_vendored directory.
tswast
reviewed
Jan 21, 2025
Comment on lines
+234
to
+236
| session.install( | ||
| "scikit-learn>=1.2.2", | ||
| ) |
There was a problem hiding this comment.
Do not install optional dependencies in unit_noextras. The intention of such test sessions is to make sure that dependencies that are marked as optional are truly optional. This risks making a forced dependency on this package.
Also, prefer removing the package from other sessions as well.
tswast
reviewed
Jan 21, 2025
Comment on lines
+226
to
+228
| session.install( | ||
| "scikit-learn>=1.2.2", | ||
| ) |
There was a problem hiding this comment.
If there is optional functionality that needs scikit-learn, please use the "extras" section in setup.py. Don't install packages this way.
tswast
changed the title
|
This is not a |
tswast
added
the
do not merge
tswast
requested changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕