Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for creating a Matrix Factorization model #1330
base: main
Are you sure you want to change the base?
feat: add support for creating a Matrix Factorization model #1330
Changes from all commits
1d39560
e19c262
1bef4a2
d157cd7
e336bde
d5f713a
5e3e443
34a60bc
c116e8a
dedef39
e5165a9
05eb854
2787178
8c66e07
086b4dd
8ed3ccd
1b4eef9
7c371ac
7498c8c
55ef06a
29805b5
8de384a
647532b
b340c4f
580de41
29ee357
bac2ece
3f22c23
213f11d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GarrettWu @shuoweil I see in #1282 you ended up passing in "id_col" as a separate argument to
fit()
instead of the class constructor. Is this a pattern you would recommend here?Note: MatrixFactorization differs somewhat from that application in that normally in scikit-learn one would have a "sparse matrix" data type (e.g. https://docs.scipy.org/doc/scipy/reference/sparse.html) where rows/cols/values would all be bundled up in one object, similar to how we are using the bigframes DataFrame for this purpose.