Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support non vectorized managed function #1373

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: support non vectorized managed function #1373

wants to merge 10 commits into from
+1,222 −285

Conversation

jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Feb 6, 2025 •
edited
Loading

b/391680147

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 6, 2025
@jialuoo jialuoo self-assigned this Feb 6, 2025
jialuoo
jialuoo commented Feb 7, 2025
View reviewed changes
bigframes/functions/_function_session.py
"""Decorator to turn a Python udf into a BigQuery managed function.
.. note::
Please make sure following is setup before using this API:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very sure about the setups. Please help verify.

@jialuoo jialuoo requested a review from shobsi February 7, 2025 18:27
@jialuoo jialuoo marked this pull request as ready for review February 7, 2025 18:27
@jialuoo jialuoo requested review from a team as code owners February 7, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi Awaiting requested review from shobsi

At least 1 approving review is required to merge this pull request.

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jialuoo