Skip to content

Conversation

@Shifat7
Copy link

@Shifat7 Shifat7 commented Apr 29, 2025

  • Introduced confidence property to represent the confidence score of Token detection.
  • Added detected_languages property to provide a list of detected languages for each Token.
  • Updated unit tests to validate the new properties.

Fixes #375 @sarath-mec 🦕

@Shifat7 Shifat7 requested review from a team as code owners April 29, 2025 14:04
@Shifat7 Shifat7 requested review from briandorsey and removed request for a team April 29, 2025 14:04
@product-auto-label product-auto-label bot added size: m Pull request size is medium. samples Issues that are directly related to samples. labels Apr 29, 2025
@Shifat7 Shifat7 changed the title Feat: added confidence score and detected languages to Token class and tests feat[Token]: added confidence score and detected languages to Token class and tests Apr 29, 2025
@Shifat7 Shifat7 changed the title feat[Token]: added confidence score and detected languages to Token class and tests feat(Token): added confidence score and detected languages to Token class and tests Apr 29, 2025
@Shifat7
Copy link
Author

Shifat7 commented Apr 29, 2025

hi @holtskinner, I've moved it to the _BasePageElement, thanks for your prompt review!

@Shifat7
Copy link
Author

Shifat7 commented Apr 30, 2025

hi @holtskinner , Ive removed the test samples as reviewed and other changes as well. Let me know if there's anything else

@Shifat7
Copy link
Author

Shifat7 commented May 4, 2025

hi @holtskinner , all done thanks for reviewing!

holtskinner
holtskinner previously approved these changes May 5, 2025
@holtskinner holtskinner changed the title feat(Token): added confidence score and detected languages to Token class and tests feat: added confidence score and detected languages to Page classes May 5, 2025
@holtskinner holtskinner enabled auto-merge (squash) May 5, 2025 15:25
@holtskinner holtskinner disabled auto-merge May 5, 2025 15:25
@holtskinner holtskinner enabled auto-merge (squash) May 5, 2025 15:25
@holtskinner holtskinner disabled auto-merge May 5, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Confidence and Language Detected in Wrapper Document

2 participants