Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

chore: add generation of pb2 files via owlbot/bazel #328

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 27, 2024

This PR is built on top of #326 and #327. This PR requires changes to build rules in googleapis/googleapis. I'll mark this PR as ready for review once the changes to the build rules are live.

I tested the changes locally using the commands below and the results are in #329

In a clone of googleapis/googleapis, run

gbazelisk build //google/cloud/orgpolicy/v1:orgpolicy-v1-py
gbazelisk build //google/cloud/orgpolicy/v2:orgpolicy-v2-py

The in a clone of this repo, run

docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo   -v <path to your bazel-bin>:/bazel-bin   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin   --source-dir /bazel-bin --dest /repo

and

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest

Fixes #22

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: orgpolicy Issues related to the googleapis/python-org-policy API. labels Dec 27, 2024
@parthea parthea changed the base branch from main to remove-proto-files December 27, 2024 19:40
@parthea parthea mentioned this pull request Dec 27, 2024
@parthea
Copy link
Contributor Author

parthea commented Dec 27, 2024

Wait for cl/710105979

@parthea parthea changed the title Add generation via bazel owlbot chore: add generation of pb2 files via owlbot/bazel Dec 27, 2024
@parthea parthea marked this pull request as ready for review January 2, 2025 19:50
@parthea parthea requested a review from a team as a code owner January 2, 2025 19:50
Base automatically changed from remove-proto-files to main January 9, 2025 20:31
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Jan 9, 2025
@parthea parthea merged commit d0fb82c into main Jan 9, 2025
24 checks passed
@parthea parthea deleted the add-generation-via-bazel-owlbot branch January 9, 2025 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: orgpolicy Issues related to the googleapis/python-org-policy API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use bazel to generate _pb2.py files
2 participants