chore: Test overriding protoc version in hermetic build integration tests #4076
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a modification to an existing integration test configuration. The primary goal is to validate the mechanism for overriding the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to add an integration test for overriding the protoc version during a hermetic build. The change itself is simple, adding a build argument to the Docker command. However, the specified version (33.2) appears to be a typo for a valid protoc version, which would likely cause the test to fail. I have provided a suggestion to correct this.
| args: [ | ||
| "build", | ||
| "--no-cache", | ||
| "--build-arg", "PROTOC_VERSION=33.2", |
There was a problem hiding this comment.
The protoc version 33.2 appears to be a typo as it's not a released version, which will likely cause this test to fail. Please use a valid protoc version to correctly test the override functionality.
"--build-arg", "PROTOC_VERSION=23.2"
|
|
1 participant
No description provided.