Skip to content

deps: update dependency ch.qos.logback:logback-core to v1.5.25 [security] #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: update dependency ch.qos.logback:logback-core to v1.5.25 [security] #4079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java-showcase/gapic-showcase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<properties>
<gapic-showcase.version>0.36.2</gapic-showcase.version>
<!-- This is the last version supporting slf4j 1.x, do not upgrade -->
<slf4j1-logback.version>1.2.13</slf4j1-logback.version>
<slf4j1-logback.version>1.5.25</slf4j1-logback.version>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on the preceding line is now incorrect with this upgrade to version 1.5.25. While Logback versions 1.3.x and 1.4.x require SLF4J 2.x, the new 1.5.x series (like the older 1.2.x series) is compatible with SLF4J 1.x.

To avoid future confusion, I recommend updating the comment on line 21. For example:

<!-- logback-classic 1.3.x/1.4.x requires slf4j-api 2.x. The 1.2.x and 1.5.x series support slf4j-api 1.x -->

Alternatively, you could remove the comment.

<slf4j2-logback.version>1.5.21</slf4j2-logback.version>
</properties>

Expand Down