Conversation
package.json
Outdated
| "configuration": { | ||
| "title": "Colab", | ||
| "properties": { | ||
| "colab.codeDiagnostics.LSP": { |
There was a problem hiding this comment.
as a starting point, "Code Diagnostics" came from Colab Web's Editor settings
There was a problem hiding this comment.
I would suspect the vast majority of users don't know what "language server protocol (LSP)" is. I'd like to name the setting (and have a description as) something which generically represents the functionality.
E.g. Code diagnostics - Enable code diagnostics powered by a connected Colab server.
@EvanWiederspan may have some suggestions too.
Should look at the verbiage the Python and Pylance extensions use. Or perhaps other language server extensions?
There was a problem hiding this comment.
nice suggestion, updated to that as a starting point! I think you're right about not using the term "LSP" - I can only find one setting that references that
here's an example from the pylance extension where type checking modes are exposed
kevineger
left a comment
kevineger
left a comment
There was a problem hiding this comment.
Let's wait to merge this until the setting does something (is wired up).
amtoney524
force-pushed
the
add-enable-lsp-setting
branch
from
ac0b994 to
ca93fa2
Compare
kevineger
force-pushed
the
ls-client
branch
2 times, most recently
from
99b4b8a to
5435139
Compare
3 participants
This PR defines a setting to enable LSP.
Extension settings:
Filtered settings:
