feat: bind a language client for the latest server#288
Open
kevineger wants to merge 1 commit intostandalone-ls-clientfrom
Open
feat: bind a language client for the latest server#288kevineger wants to merge 1 commit intostandalone-ls-clientfrom
kevineger wants to merge 1 commit intostandalone-ls-clientfrom
Conversation
There are two inputs that determine how a language client is bound/registered: 1. Does the user have a valid auth session? 2. What's the latest server? This controller listens to those two events and manages the lifecycle of the corresponding server. Here we use `LatestCancelable` to do the `async` _spin up_ in response to the aforementioned sync events. To facilitate testing and keep the logging in a centralized spot, when constructed we listen to the `ServerChangeEvent` this class emits.
amtoney524
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two inputs that determine how a language client is bound/registered:
This controller listens to those two events and manages the lifecycle of the corresponding server. Here we use
LatestCancelableto do theasyncspin up in response to the aforementioned sync events. To facilitate testing and keep the logging in a centralized spot, when constructed we listen to theServerChangeEventthis class emits.