Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Fix crash when arcore not installed #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arseneHuot
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@@ -527,7 +529,7 @@ public void onDrawFrame(GL10 gl) {
mBackgroundRenderer.draw(mFrame);

// Draw Lines
if (mFrame.getCamera().getTrackingState() == TrackingState.TRACKING) {
if (mFrame != null && mFrame.getCamera().getTrackingState() == TrackingState.TRACKING) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will prove to be helpful because if in case mFrame is null, the condition will still go false without notifying the developer about it.

@brijeshshah13
Copy link
Contributor

@HalfdanJ You can close this PR as well. Changes are already included in #9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants