[write-fonts] VARC table #1716
Merged
[write-fonts] VARC table #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoncozens
force-pushed
the
write-varc
branch
from
ce25133 to
2d42491
Compare
behdad
reviewed
Jan 19, 2026
behdad
reviewed
Jan 19, 2026
| pub condition_index: Option<VarcVariationIndex>, | ||
| pub axis_values: Option<BTreeMap<u16, f32>>, | ||
| pub axis_values_var_index: Option<VarcVariationIndex>, | ||
| pub transform: DecomposedTransform, |
Contributor
There was a problem hiding this comment.
It came as a surprise to me that DecomposedTransform has optional fields. Maybe the name should reflect that?
Contributor
|
This looks great to me! Thanks for working on it. |
Contributor
Author
|
One thing to mention is that this is the least intrusive approach. Because of that, we construct a bunch of |
cmyr
approved these changes
Jan 20, 2026
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
A few little notes inline but overall this looks excellent, thanks!
Co-authored-by: Colin Rofls <colin@cmyr.net>
simoncozens
force-pushed
the
write-varc
branch
from
8736481 to
8f6dd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new MultiItemVariationStoreBuilder (abstracting out common functionality between it and the VariationStoreBuilder), and implements write-fonts support for the VARC table.
The
varc.rstests provide some examples of how to use this to build VARC tables.