Merge pull request #866 from googlefonts/prune-zero-class-variable-kerns

[kernFeatureWriter] ignore zero-valued class kern pairs when building variable kern
googlefonts · Aug 29, 2024 · 8ec3ef3 · 8ec3ef3
2 parents 27f7e9b + 22a699e
commit 8ec3ef3
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 1 deletion.
diff --git a/Lib/ufo2ft/featureWriters/kernFeatureWriter.py b/Lib/ufo2ft/featureWriters/kernFeatureWriter.py
@@ -551,7 +551,13 @@ def getVariableKerningPairs(
             if default_location not in value.values:
                 value.values[default_location] = 0
             value = collapse_varscalar(value)
-            result.append(KerningPair(side1, side2, value))
+            pair = KerningPair(side1, side2, value)
+            # Ignore zero-valued class kern pairs. They are the most general
+            # kerns, so they don't override anything else like glyph kerns would
+            # and zero is the default.
+            if pair.firstIsClass and pair.secondIsClass and pair.value == 0:
+                continue
+            result.append(pair)
 
         return result
 

diff --git a/tests/data/TestVarfea-Regular.ufo/groups.plist b/tests/data/TestVarfea-Regular.ufo/groups.plist
@@ -0,0 +1,14 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+  <dict>
+    <key>public.kern1.a</key>
+    <array>
+      <string>a</string>
+    </array>
+    <key>public.kern2.a</key>
+    <array>
+      <string>a</string>
+    </array>
+  </dict>
+</plist>
diff --git a/tests/data/TestVarfea-Regular.ufo/kerning.plist b/tests/data/TestVarfea-Regular.ufo/kerning.plist
@@ -7,5 +7,10 @@
       <key>alef-ar.fina</key>
       <integer>15</integer>
     </dict>
+    <key>public.kern1.a</key>
+    <dict>
+      <key>public.kern2.a</key>
+      <integer>0</integer>
+    </dict>
   </dict>
 </plist>
diff --git a/tests/featureWriters/variableFeatureWriter_test.py b/tests/featureWriters/variableFeatureWriter_test.py
@@ -103,7 +103,9 @@ def test_variable_features_old_kern_writer(FontClass):
         markClass dotabove-ar <anchor (wght=100:100 wght=1000:125) (wght=100:320 wght=1000:416)> @MC_top;
         markClass gravecmb <anchor 250 400> @MC_top;
 
+        @kern1.a = [a];
         @kern1.alef = [alef-ar.fina];
+        @kern2.a = [a];
         @kern2.alef = [alef-ar.fina];
 
         lookup kern_rtl {