markFeatureWriter: Support contextual anchors #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges glyphsLib’s ContextualMarkFeatureWriter subclass back into MarkFeatureWriter. This is a mechanical merge with only the bare minimum changes to get things working. Some bug fixes and refactoring will happen in next commits.
Check `key` is not empty before accessing first character.
khaledhosny
force-pushed
the
contextual-mark-feature-writer
branch
from
6466a34
to
a6e57b3
Compare
khaledhosny
force-pushed
the
contextual-mark-feature-writer
branch
from
472eb74
to
e5c4764
Compare
|
thanks Khaled! i'm happy when Simon is |
khaledhosny
force-pushed
the
contextual-mark-feature-writer
branch
from
e5c4764
to
4004817
Compare
khaledhosny
force-pushed
the
contextual-mark-feature-writer
branch
from
4004817
to
241cb6d
Compare
…quested We were trying to access non-existent features["mark"] when mark feature was disabled.
Otherwise we end up with positioning statements that have duplicated mark classes like this: pos base a <anchor 200 200> mark @MC_top <anchor 100 200> mark @MC_top; (one is the regular anchor, and the other is the contextual one). Which makes no sense (feaLib shouldn’t probably allow the same mark class to be used multiple times in the same statement).
khaledhosny
force-pushed
the
contextual-mark-feature-writer
branch
from
241cb6d
to
e6ec270
Compare
|
@simoncozens ping |
|
I’m going to merge this and #871 as I’m blocked by both. If there are issues, we can always fix them later. |
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges glyphsLib’s ContextualMarkFeatureWriter subclass back into MarkFeatureWriter.