Refactor Objects in ViewTrips Directory #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anan-ya-y
approved these changes
Jul 23, 2020
keiffer01
reviewed
Jul 24, 2020
keiffer01
approved these changes
Jul 27, 2020
HiramSilvey
requested changes
Jul 29, 2020
…rent timezone until fixing #89.
Issue earlier with error component must have been a different error that was accidentally fixed when switching to the asynchronous version of this function.
…les for keys rather than initialize empty objects and inserting key:value pairs.
HiramSilvey
approved these changes
Jul 30, 2020
The merge did not update one field from struct to dict syntax and thus the field did not exist == undef.
HiramSilvey
requested changes
Jul 31, 2020
HiramSilvey
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Updates all JS objects to use the dict rather than struct format for updating/accessing in order to use the constants in
database.jsin all appropriate cases.Is this fixing an issue?
fixes #84
Are there more details that are relevant?
Updated fields in
database.jsfor more clarity:TRIPS_NAME-->TRIPS_TITLETRIPS_CREATION_TIME-->TRIPS_UPDATE_TIMESTAMPAlso had to create a new firestore index as a result.
Check lists (check
xin[ ]of list items)Any additional comments?