Lint07 #22
Open
Lint07 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokeke
approved these changes
Sep 17, 2020
Comment on lines
7
to
28
| Example: | ||
|
|
||
| ```go | ||
| // LintProducedAtDate checks that an OCSP Response ProducedAt date is no more than ProducedAtLimit in the past | ||
| // Source: Apple Lints 03 & 05 | ||
| func LintProducedAtDate(resp *ocsp.Response, leafCert *x509.Certificate, issuerCert *x509.Certificate) (LintStatus, string) { | ||
| // default assume certificate being checked is a subscriber certificate | ||
| certType := "subscriber certificate" | ||
| producedAtLimit := ProducedAtLimitSubscriber | ||
| if leafCert != nil && leafCert.IsCA { | ||
| certType = "subordinate CA certificate" | ||
| producedAtLimit = ProducedAtLimitCA | ||
| // CheckStatus checks that the status of the OCSP response matches what the user expects it to be | ||
| // Source: Apple Lint 07 | ||
| func CheckStatus(resp *ocsp.Response, leafCert *x509.Certificate, issuerCert *x509.Certificate, lintOpts *LintOpts) (LintStatus, string) { | ||
| if lintOpts.ExpectedStatus == None { | ||
| return Passed, fmt.Sprintf("User did not specify an expected status (fyi OCSP response status was %s)", StatusIntMap[resp.Status]) | ||
| } | ||
|
|
||
| expectedStatus := ocsp.Good | ||
| if lintOpts.ExpectedStatus == Revoked { | ||
| expectedStatus = ocsp.Revoked | ||
| } | ||
|
|
||
| limit, err := time.ParseDuration(producedAtLimit) | ||
|
|
||
| if err != nil { | ||
| return Error, fmt.Sprintf("Could not parse time duration %s", producedAtLimit) | ||
| } | ||
|
|
||
| if time.Since(resp.ProducedAt) > limit { | ||
| return Failed, fmt.Sprintf("OCSP Response producedAt date %s for %s is more than %s in the past", | ||
| resp.ProducedAt, certType, DurationToString[producedAtLimit]) | ||
| if resp.Status != expectedStatus { | ||
| return Failed, fmt.Sprintf("Expected status %s, OCSP response status was %s", lintOpts.ExpectedStatus, StatusIntMap[resp.Status]) | ||
| } | ||
|
|
||
| return Passed, fmt.Sprintf("OCSP Response producedAt date %s for %s is within %s of the past", | ||
| resp.ProducedAt, certType, DurationToString[producedAtLimit]) | ||
| return Passed, fmt.Sprintf("OCSP Response status matched expected status of %s", lintOpts.ExpectedStatus) | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Like I think I mentioned in another PR, every time the code changes you'll have to. remember to come back and update this too. It might be better to just point to a file and a function in the file rather than copy-pasting the whole code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.