Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moves the key function call to inside of the GoogleMap composable #7

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dkhawk
Copy link
Collaborator

@dkhawk dkhawk commented Oct 2, 2024

feat: update to Places SDK 4.0.0. remove places-ktx dependency
chore: clean up log statements and unused code

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

feat: update to Places SDK 4.0.0.  remove places-ktx dependency
chore: clean up log statements and unused code
@dkhawk dkhawk requested a review from kikoso October 2, 2024 20:22
@dkhawk dkhawk mentioned this pull request Oct 2, 2024
state = userMarker,
zIndex = 2f
)
key(landmarkMarkers) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion!

@googlemaps-bot
Copy link

Code Coverage

Overall Project 2.58%

There is no coverage information present for the Files changed

Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The problem with the InfoWindow seems better solved, libraries updated and a bit of general cleaning.

@dkhawk dkhawk merged commit 349dd68 into main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants