feat: custom template delimiter #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiusCraft
force-pushed
the
feat/template-delimiter
branch
from
13e43e7 to
f8bb7c0
Compare
14 tasks
xushiwei
reviewed
Feb 1, 2024
| @@ -82,6 +82,12 @@ func (p *App) Static__2(pattern string, fs http.FileSystem, allowRedirect ...boo | |||
| p.StaticHttp(pattern, fs, allowRedirect...) | |||
| } | |||
|
|
|||
| // custom delimiter, | |||
| // example:{{ }} => ${ }$ | |||
| func (p *App) SetDelims(left, right string) { | |||
There was a problem hiding this comment.
Why we should support custom delimiter?
There was a problem hiding this comment.
scene
It conflicts with yap
vue:
<script setup>
import { ref } from 'vue'
const message = ref('Hello World!')
</script>
<template>
<h1>{{ message }}</h1>
</template>to prevent conflicts with the front-end framework, developers can decide to change delimiter of the template
example vue:
goplus/community#63 (comment)
Additionally, most go web frameworks support modifying delimiters.
gin: https://github.com/gin-gonic/gin/blob/v1.9.1/gin.go#L239
beego: https://pkg.go.dev/github.com/astaxie/beego#WebConfig.TemplateLeft
@xushiwei PTAL
|
YAP doesn't want to support custom delimiter since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default delimiter: {{ }}
set delims:
yap.SetDelims("${", "}$")orsetDelims "${", "}$"