Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S24 privacy combined profile #2355

Open
wants to merge 62 commits into
base: develop
Choose a base branch
from
Open

Conversation

jsenning
Copy link
Contributor

This PR replaces #2031

@ArabellaJi began working on this in 2023 and did most of the heavy lifting. She began with the intention of giving FacStaff a mechanism to optionally display their mobile phone number. This then expanded to provide privacy controls for other items on the FacStaff personal profile. Before she handed it off at the start of the summer, she had also expanded her work so that student data (currently mobile phone and home address) used the same mechanisms.

In the past weeks we have continued this work to more completely integrate the new privacy settings and adjusting profile view models to allow individual profile elements have individual boolean values to indicate the user has requested they be private. Doing this meant that many of the profile fields have changed from strings to objects that contain a string and a privacy flag. For example, in both the UI and API the mobile phone field is now has type ProfileItem that is a class with two fields value and isPrivate. The value field is the string representing the phone number, and the isPrivate field is a boolean that is true if the should be treated as confidential (and shown in red). Of course, data the viewing user is not allowed to see is not sent from the API, so the isPrivate field being true means that the viewing user is authorized to see the information but the color reminds them that the information is restricted and should be treated as such.

This change deprecates the use of the "KeepPrivate" profile field for faculty staff accounts and the "isMobilePhonePrivate" field for student accounts (although one outstanding issue is the need to ensure that student mobile phone privacy settings here are appropriately reflected in the Jenzabar database.)

Some profile information still use other types of privacy controls. One example is Clifton Strengths (although this might be an easy fix). Another is the privacy settings for alumni. We hope that in the near future these can be modified to use the new privacy settings.

Wenlan Ji and others added 30 commits July 14, 2023 17:24
@Luke-W-Hart Luke-W-Hart added the s24 Summer Practicum 2024 label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s24 Summer Practicum 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants