-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WMR RD View Setup #2387
WMR RD View Setup #2387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay Mya this looks really great! I added some quick comments, and if you could paste a screenshot of what the screen looks like that would look really awesome!
src/views/Housing/index.jsx
Outdated
</Grid> | ||
); | ||
const Housing = () => { | ||
const isFaculty = useAuthGroups(AuthGroup.Faculty); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an isFacStaff
function that we can import...
import { Profile as profileType, isFacStaff as checkIsFacStaff } from 'services/user';
Hopefully this works?
src/views/Housing/index.jsx
Outdated
const Housing = () => { | ||
const isFaculty = useAuthGroups(AuthGroup.Faculty); | ||
|
||
if (isFaculty) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it does work then this would be isFacStaff
instead I think
Again not sure if it does work but worth a try? If not then we can use the auth groups
const [open, setOpen] = useState(false); | ||
|
||
return ( | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in React instead of using divs we just use empty jsx fragments, like
<></>
Hi Danya, Thank you for your suggestions! I changed how we check if the user is faculty to what you suggested and it worked so we can use it. I also changed the div to <> </> and it caused no issues. Let me know if you have any other suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Changes made in PR: