Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wmr - create more components for ResidentView #2389

Merged
merged 2 commits into from
Oct 14, 2024
Merged

wmr - create more components for ResidentView #2389

merged 2 commits into from
Oct 14, 2024

Conversation

jtasonye
Copy link

Changes made in PR:

  • Created MyHall component
  • Created MyRA component
  • Created OnDuty component
  • Created Resources component
  • Added all components to the Housing index.jsx

@jtasonye jtasonye changed the title Created more components for ResidentView Create more components for ResidentView Oct 13, 2024
@dli505 dli505 self-requested a review October 14, 2024 00:07
dli505
dli505 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@dli505 dli505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The use of <strong></strong> tags is nagging me at the back of my head (I think...? there's another way to do it in MUI/React) but that's a problem for later :)

@dli505 dli505 merged commit a361b9a into gordon-cs:wheres-my-ra Oct 14, 2024
1 check passed
@jtasonye jtasonye changed the title Create more components for ResidentView wmr create more components for ResidentView Oct 29, 2024
@jtasonye jtasonye changed the title wmr create more components for ResidentView wmr - create more components for ResidentView Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dli505 dli505 dli505 approved these changes

Assignees

@jtasonye jtasonye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtasonye @dli505