Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Report Button #2413

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Delete Report Button #2413

merged 6 commits into from
Nov 4, 2024

Conversation

erandersen21
Copy link

@erandersen21 erandersen21 commented Nov 2, 2024

Sets an item's status to deleted and moves it to past reports, but does not include the confirmation pop-up. PR also contains status update front-end service.
API: gordon-cs/gordon-360-api#1083

Copy link
Contributor

@Luke-W-Hart Luke-W-Hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Watched as it worked.

Copy link
Contributor

@Centerville1 Centerville1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, but let's wait to merge until we add the pop-up confirmation modal.

@Luke-W-Hart Luke-W-Hart changed the title Delete Button Finished (without confirmation pop-up) Delete Report Button Nov 3, 2024
const handleDeleteClick = (reportId: string) => {
setReportToDelete(reportId);
setDeleteModalOpen(true);
console.log(reportId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this console.log?
If so then LGTM, if not then it can be removed and that also LGTM!

@Luke-W-Hart Luke-W-Hart self-requested a review November 4, 2024 01:52
@Centerville1 Centerville1 merged commit d3c95f6 into LostAndFound Nov 4, 2024
1 check passed
@Centerville1 Centerville1 deleted the DeleteButton-Andersen branch November 4, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants