-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Report Button #2413
Delete Report Button #2413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Watched as it worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, but let's wait to merge until we add the pop-up confirmation modal.
const handleDeleteClick = (reportId: string) => { | ||
setReportToDelete(reportId); | ||
setDeleteModalOpen(true); | ||
console.log(reportId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this console.log?
If so then LGTM, if not then it can be removed and that also LGTM!
Sets an item's status to deleted and moves it to past reports, but does not include the confirmation pop-up. PR also contains status update front-end service.
API: gordon-cs/gordon-360-api#1083